diff: add headers to file-by-file mode #4024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowles
force-pushed
the
diff
branch
2 times, most recently
from
fda3563 to
481cf82
Compare
fowles
force-pushed
the
diff
branch
2 times, most recently
from
1966eba to
992c78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on earlier discussion we were undecided about whether external tools in file-by-file mode should have headers. This change adds them fairly naively. We probably want to consider more carefully how to handle differences like streamed/TUI/GUI diff tools and waiting for them to finish or doing them in parallel.
Checklist
If applicable:
CHANGELOG.md